Uninstall opencv included in base image#7626
Merged
Merged
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Nic-Ma
approved these changes
Apr 11, 2024
mingxin-zheng
approved these changes
Apr 11, 2024
mingxin-zheng
left a comment
mingxin-zheng
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. The opencv in the pytorch container doesn't include packages in opencv-headless, and potentially causes issues for video processing.
Contributor
|
Could you please run this notebook after uninstall the opencv? The VideoFileDataset is using the opencv lib. I am afraid of removing the lib impacts it. Thanks, |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
Contributor
Author
Add |
Contributor
Author
|
/build |
binliunls
approved these changes
Apr 12, 2024
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tutorial #1689
Description
Uninstall opencv included in base image.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.