Conversation
- remove dsm_version - use SynologyDSMRequestException for failed requests
- Add api.request(api, method, params=None)
- Add error handling by API code
Quentame
force-pushed
the
dsm/api_discovery
branch
from
44be415 to
eec4d9a
Compare
This was referenced Apr 21, 2020
Collaborator
Author
|
Merging because will be used in HA, will release fixes if needed. |
Quentame
pushed a commit
to Quentame/python-synology
that referenced
this pull request
Aug 12, 2021
Bumps [reorder-python-imports](https://github.com/asottile/reorder_python_imports) from 2.3.6 to 2.4.0. - [Release notes](https://github.com/asottile/reorder_python_imports/releases) - [Commits](asottile/reorder-python-imports@v2.3.6...v2.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEW
GETany DSM API withsynology_dsm.get(api: str, method: str, params: dict, **kwargs)POSTany DSM API withsynology_dsm.post(api: str, method: str, params: dict, data: dict, files: dict, **kwargs)SynologyDSMAPINotExistsExceptionif the API does not existsSynologyDSMAPIErrorExceptionif the API respond with an errorSynologyDSMRequestExceptionif there is aRequestException(mainlyConnectionErrororSSLError) or aJSONDecodeErrorversionpropertyBUG FIXES
BREAKING CHANGES
dsm_versionconstructor param has been removed (APIs are now auto-discovered + DSM version is fetched with the "SYNO.DSM.Info" API)IMPROVEMENTS