-
Notifications
You must be signed in to change notification settings - Fork 39
Add Core System and Upgrade APIs info and actions #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ProtoThis , |
Quentame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the test data accordingly.
In tests/api_data/dsm_6/core/, see other exemple for filename and const pattern.
Don't worry if you don't add a test, but at least the raw_data so someone else can do so.
* Migrate to Python 3.6+ Drop support of Python < 3.6 - remove six + future deps + usage - update deps - remove encoding - remove (object) * Fix pylint - pip3 super() style - remove simplejson dep + usage * Black format * lint setup * Travix CI py version * Use f string * Basic Typing * Revert setup version bump
|
Be aware for Python 3.6+ now : #70 |
Quentame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is conflits to resolve, then we are good to merge
|
To solve conflits I recommand you to rebase on master, manage rebase conflicts, then force push |
|
thanks for hint to solve conflicts, but I'm a beginner when it comes to git and therefore I do not have any idea how to do this :/ |
|
Do you want to try ? |
|
I tried it now three times, but did not get it solved :( |
|
yeah ... I get the conflict resolved :) |
Hello,
this PR contains:
regards,
Michael