Merged
Conversation
Closed
Quentame
changed the title
Quentame
requested changes
Oct 19, 2020
Collaborator
Quentame
left a comment
Quentame
left a comment
There was a problem hiding this comment.
Can you just rename ssl_validation to verify_ssl, uselly this is the name we gave to this function.
HA and Synology Surveillance Station lib are doing the same
Collaborator
|
Tests 🆗 |
Quentame
added
enhancement
Hacktoberfest
mib1185
referenced
this pull request
in mib1185/python-synology
Dec 19, 2020
* add parameter ssl_validation * add parameter ssl_validation * rename to verify_ssl * rename to verify_ssl * object property use_https not needed * black * VALID_SSL_VERIFICATION --> VALID_SSL_VERIFY * disable_warnings on urllib only if not verify_ssl * VALID_SSL_VERIFY --> VALID_VERIFY_SSL * VALID_SSL --> VALID_HTTPS * Add test * black again * Add test Co-authored-by: Quentin POLLET <polletquentin74@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
fix #48
SSL validation is default disabled to not break existing environments.
If
ssl_validation=Truean SynologyDSMRequestException is thrown in case of validation error with details like: