isAppStore is true on sideloaded IPA via AltStore

[pfych]

When sideloading via the AltStore the Bundle identifier isn't changed, causing the isAppStore check to incorrectly set to true.

Provenance/PVUI/Sources/PVSwiftUI/App Delegate/PVAppDelegate.swift

Lines 75 to 91 in 521c3ee

	public var isAppStore: Bool {
	guard Bundle.main.bundleIdentifier!.hasPrefix("org.provenance-emu.provenance") else {
	ILOG("Bundle id \(Bundle.main.bundleIdentifier ?? "null") is NOT official. Disabling Provenance Plus checks.")
	return false
	}
	guard let appType = Bundle.main.infoDictionary?["PVAppType"] as? String else {
	ILOG("appType \( Bundle.main.infoDictionary?["PVAppType"] ?? "null") is NOT official. Disabling Provenance Plus checks.")
	return false
	}
	let isAppStore = appType.lowercased().contains("appstore")
	if isAppStore {
	ILOG("isAppStore true.")
	} else {
	ILOG("isAppStore false.")
	}
	return isAppStore
	}

Expected:

isAppStore should be false

Actual:

isAppStore is true

Reproduce:

1. Download IPA from github
2. Sideload with AltStore
3. Launch Provenance

APP VERSION

3.1.0

APP SOURCE

• Provenance-Emu GitHub  (Official)

INSTALLED BY

Side-Loading

PLATFORM

iOS

iOS/tvOS VERSION

18.6

---

^{🚫 We DO NOT support unofficial builds installed from 3rd-party sites. (Official Install)
❓ Need help or have a suggestion? Join our Official Discord}

[dnicolson]

AltStore does seem to change the bundle identifier, but it just appends the randomized string from the developer profile.

If you change the bundle identifier to something completely unique, the isAppStore value will be false. Not sure if that’s intentional, though.

[pfych]

Can confirm - my bundle identifier is org.provenance-emu.provenance.PTF96E42L3

[JoeMatt]

The code is technically working as intended, I have to figure out how to deal with the random string, I guess just look for the exact bundle ID. I was cautioius to do this incase app store also added random extensions.

[JoeMatt]

I think this is fixed in 3.2.0

[pfych]

Still experiencing this issue in 3.2.1 when sideloaded via altstore

[JoeMatt]

this should be fixed fr fr, this code was re-written for 3.3.x

You do need to change your bundle id from the stock one, but it no longer partially matches just the front part