Skip to content

Add check for empty errorMsg to tableprovider#222

Merged
KentMossback merged 2 commits intomainfrom
fix/add-check-for-empty-errormsg-to-tableprovider
Jul 31, 2024
Merged

Add check for empty errorMsg to tableprovider#222
KentMossback merged 2 commits intomainfrom
fix/add-check-for-empty-errormsg-to-tableprovider

Conversation

@SjurSutterudSagen
Copy link
Contributor

Since we do not want unecessary warnings or errors in the console, we need to remove the ones that appear. This fixes two errors when loading the site, because the useEffect in tableprovider for showing the errors in the console was missing a check for an empty string.

Since we do not want unecessary warnings or errors in the console, we
need to remove the ones that appear. This fixes two errors when loading
the site, because the useEffect for showing the errors in the console
was missing a check for an empty string.
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d6f1cd
Status: ✅  Deploy successful!
Preview URL: https://ed1a143e.pxweb2.pages.dev
Branch Preview URL: https://fix-add-check-for-empty-erro.pxweb2.pages.dev

View logs

Copy link
Contributor

@KentMossback KentMossback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KentMossback KentMossback merged commit 8771438 into main Jul 31, 2024
@KentMossback KentMossback deleted the fix/add-check-for-empty-errormsg-to-tableprovider branch July 31, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants