Open
Conversation
jayvdb
force-pushed
the
limit-differentForks-scope
branch
from
123be91 to
522b927
Compare
Alternate if & try forks are always in the same scope. Rearranging the code a little allows for differentForks to only be called on redefinitions within the same scope, and inside differentForks the use of getCommonAncestor can be limited to finding ancestors only when in current scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate if & try forks are always in the same scope.
Rearranging the code a little allows for differentForks
to only be called on redefinitions within the same scope,
and inside differentForks the use of getCommonAncestor
can be limited to finding ancestors only when in current
scope.