Conversation
| _name = normpath(name) | ||
| except IllegalBackReference: | ||
| # Back references outside root, must be up to no good. | ||
| pass |
There was a problem hiding this comment.
Rather than always silently ignoring back-reference errors, I wonder if it'd be worth ignoring them by default, with an FS init-option to re-throw the back-reference errors?
There was a problem hiding this comment.
I pondered that, but if we raise an error at this point then a tar with a single badly formatted entry would prevent the tar from being opened. At least this way you could access any other valid entries via the TarFS.
I'm assuming that an invalid path here would be a fairly exotic thing, and there wouldn't be a great utility in reporting it back to the user. As far as I can tell, the tarfile module also silently ignores these errors, so that swayed me.
I'll wait until somebody asks for it or I can think of an argument against ignoring bad entries...
3 participants
Type of changes
Checklist
Description
Fixes #284
Also dropped Python3.3 support to solve Github security warning. We support Python3.4 - Python3.7 and 3.8 is around the corner, so I think its time. Hope there is no pushback to that.