Merged
Conversation
fafhrd91
reviewed
May 1, 2018
| // N.B: names: "librust2py" must be the name of the `.so` or `.pyd` file | ||
| /// This module is implemented in Rust. | ||
| #[py::modinit(rust2py)] | ||
| #[pymodinit(rust2py)] |
Contributor
There was a problem hiding this comment.
What is the reason for this change?
Member
Author
There was a problem hiding this comment.
py::modinit doesn't work without the proc_macro_path_invoc feature, which isn't expected to be stabilized soon (unlike proc macros and specialization).
fafhrd91
approved these changes
May 1, 2018
Contributor
|
you should have permission to merge |
Member
Author
|
Yes, thanks! |
Member
Author
|
@fafhrd91 Do you have any policy on when to make pull requests and when to directly push to master? |
Contributor
|
I don't really have any policy, but master branch is protected :) |
Contributor
This was referenced May 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#50120 has made two breaking changes that break pyo3's compilation:
proc_macro_path_invoc. This means that e.g.#[py::modinit(rust2py)]fails to compile.rust2pyand not(rust2py).This pull request fixes both. I've tried to avoid introducing breaking changes and instead replaced
py::modinitwith apymodinitalias. I wouldn't mind removing the alias or renaming the proc macros.