Skip to content

toggle for (concurrent) monthly ERA5 requests; progressbar disabled by default #372

Merged
fneum merged 12 commits intomasterfrom
monthly-requests
Aug 23, 2024
Merged

toggle for (concurrent) monthly ERA5 requests; progressbar disabled by default #372
fneum merged 12 commits intomasterfrom
monthly-requests

Conversation

@fneum
Copy link
Copy Markdown
Member

@fneum fneum commented Aug 13, 2024

Closes #371.

Changes proposed in this Pull Request

Adds option to toggle whether ERA5 downloads are requested in monthly or annual chunks with option to place concurrent requests with keyword argument cutout.prepare(monthly_requests=False, concurrent_requests=False).

Potential performance improvements and functionality tests shown in #371.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@fneum fneum marked this pull request as ready for review August 14, 2024 08:44
@fneum fneum requested a review from FabianHofmann August 14, 2024 12:18
@fneum
Copy link
Copy Markdown
Member Author

fneum commented Aug 14, 2024

See performance checks in #371

@FabianHofmann
Copy link
Copy Markdown
Contributor

This is great. Would you mind putting a test there for checking both functionalities? Otherwise feel free to merge

@fneum fneum changed the title add toggle to request ERA5 in annual or monthly chunks toggle for (concurrent) monthly ERA5 requests; progressbar disabled by default Aug 17, 2024
@fneum
Copy link
Copy Markdown
Member Author

fneum commented Aug 23, 2024

I have tested this extensively and it works well!

@fneum fneum merged commit 0b0933f into master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dramatically different download speeds between versions

2 participants