feat: add NPC scale support for Minecraft 1.20.5+#218
Open
KevinDavai wants to merge 1 commit intoPyrbu:2.Xfrom
Open
feat: add NPC scale support for Minecraft 1.20.5+#218KevinDavai wants to merge 1 commit intoPyrbu:2.Xfrom
KevinDavai wants to merge 1 commit intoPyrbu:2.Xfrom
Conversation
KevinDavai
commented
Jan 11, 2026
- Registered new AttributeProperty "scale" in EntityPropertyRegistryImpl
- Only active for versions 1.20.5 and above
Collaborator
|
@KevinDavai Simply adding the property isn’t sufficient. The look system also needs to be updated to account for scale when computing the target yaw and pitch for the NPC to face the player. I’ve tried adjusting this within the current setup, but it doesn’t behave correctly. To fix this properly, the look behavior needs to be reworked on the backend so scale is consistently factored into the calculations. I'll try to work on it today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.