Repository navigation
Avoid panics in Quantum Shannon Decomposition Rust code (backport #15635) - #15802
Conversation
|
Cherry-pick of 02fef9b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
* catch rust panic errors in qs_decomposition * add try/catch in qs_decompsition, and fall to Isometry if needed * add test, based on issue 15610 * formatting * add release notes * add Isometry to the test * Improving error handling for QSD synthesis * Fix misprint * enhance failed matrix test * Changing RuntimeError to QiskitError * comment * not discarding info for CircuitDataError * tightening try-except blocks * further fix to avoid infinite recursion * Update release note --------- Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 02fef9b)
5e35a1d to
f267d5f
Compare
Pull Request Test Coverage Report for Build 23024350432Details
💛 - Coveralls |
Summary
close #15610 .
Since iterative Quantum Shannon Decomposition may provide imprecise matrices, and the rust code may panic when calcualting SVD or Schur decompositions, we use the
Isometrydecomposition in such cases.Details and comments
This is an automatic backport of pull request #15635 done by [Mergify](https://mergify.com).