Repository navigation
Fix global phase in TwoQubitWeylDecomposition.circuit - #17432
Open
Ziqi (Adam) CHEN (ChenziqiAdam) wants to merge 1 commit into
Open
Ziqi (Adam) CHEN (ChenziqiAdam) wants to merge 1 commit into
Ziqi (Adam) CHEN (ChenziqiAdam) wants to merge 1 commit into
Conversation
Ziqi (Adam) CHEN (ChenziqiAdam)
requested a review
from a team
as a code owner
November 5, 2026 07:47
Ziqi (Adam) CHEN (ChenziqiAdam)
requested a review
from Gadi Aleksandrowicz (gadial)
November 5, 2026 07:47
qiskit-bot
added
the
Community PR
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Shelly Garion (ShellyGarion)
added
mod: synthesis
Changelog: Fixed
Member
|
Ziqi (Adam) CHEN (@ChenziqiAdam) - could you please sign the CLA? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17401.
TwoQubitWeylDecomposition.circuit()returned a circuit with the wrong global phase (off by a factor of -1) for roughly half of all two-qubit unitaries. The decomposition's attributes reassembleUexactly, so onlycircuit()was affected.AI/LLM disclosure