Skip to content

FEAT: Add Shorrocks mobility index - #447

Merged
mmcky merged 3 commits into
masterfrom
add-shorrock
Dec 10, 2018
Merged

mmcky merged 3 commits into
masterfrom
add-shorrock

Conversation

@natashawatkins

@natashawatkins natashawatkins commented Dec 7, 2018 •

Copy link
Copy Markdown
Member

Adds the Shorrocks mobility index as described in this paper on page 13: https://www.econ.nyu.edu/user/bisina/RevisionAugust.pdf

@natashawatkins
natashawatkins requested a review from jstac December 7, 2018 05:33
@natashawatkins natashawatkins changed the title Add Shorrocks inequality index Add Shorrocks mobility index Dec 7, 2018
@mmcky mmcky changed the title Add Shorrocks mobility index FEAT: Add Shorrocks mobility index Dec 7, 2018
@mmcky

mmcky commented Dec 7, 2018

Copy link
Copy Markdown
Contributor
  • update docs to include

@natashawatkins

Copy link
Copy Markdown
Member Author

I was trying to follow the instructions here: https://github.com/QuantEcon/QuantEcon.py/tree/master/docs but wasn't able to compile the docs - was getting an import error

Is my commit sufficient though?

@natashawatkins

Copy link
Copy Markdown
Member Author

Also I think we need to add documentation for the nelder_mead algorithm added by @QBatista ?

@mmcky

mmcky commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

probably need to add it to the index?
we do - but please don't add that in this PR. We will make a separate PR to add nelder_mead

@mmcky

mmcky commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

thanks @natashawatkins I will dig into this docs issue on Monday.

@jstac

jstac commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

Nice work @natashawatkins. Nice code and tests.

Let's try to remember to get this in a notebook somehow, so we make it known.

@cdagnino FYI, since I seem to remember you were looking at mobility indices.

@coveralls

coveralls commented Dec 8, 2018 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.006%) to 94.575% when pulling 0a9c1f9 on add-shorrock into 3772fdd on master.

@mmcky

mmcky commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

thanks @natashawatkins I will merge this PR and submit a fix for docs

@mmcky
mmcky merged commit 6ba4ba0 into master Dec 10, 2018
@mmcky
mmcky deleted the add-shorrock branch December 10, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants