Skip to content

Small tests for infinite partition function#273

Merged
leburgel merged 5 commits into
masterfrom
ksh/ztests
Oct 23, 2025
Merged

Small tests for infinite partition function#273
leburgel merged 5 commits into
masterfrom
ksh/ztests

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 9, 2025

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov

codecov Bot commented Oct 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel

Copy link
Copy Markdown
Member

Test failures seem unrelated, something in the Lorentzian broadening test for the SVD pullback. Anything we should worry about @pbrehmer?

@leburgel leburgel merged commit 40d909b into master Oct 23, 2025
51 checks passed
@leburgel leburgel deleted the ksh/ztests branch October 23, 2025 17:19
@pbrehmer

Copy link
Copy Markdown
Collaborator

Test failures seem unrelated, something in the Lorentzian broadening test for the SVD pullback. Anything we should worry about @pbrehmer?

No this seems unproblematic. I would assume that since we now obtain more accurate gradients due to #276 some of the SVD gradient values have changed. In that particular test that fails, the unbroadened gradient is now slightly more accurate when there are degenerate singular values but it is still deviating from the broadened gradients significantly (i.e. suffers from the same problem of divergences). I will just need to lower the tolerance slightly to make this stable again; I'll do that in #270 since there we anyway need to think about the SVD broadening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants