Conversation
|
Looks fine. Check why the logos didn't load: https://qubes-doc--1656.org.readthedocs.build/en/1656/developer/general/visual-style-guide.html#logo-assets |
|
I think this is a regression:
I would prefer a restructuredtext version, using |
0f6d31b to
9461aad
Compare
|
I removed the inserted html, let me know what you think.
Because I didn't find a cdn that provides |
|
That's better! Including any CSS font, even with a CDN is overkill. Using an image instead would be more appropriate. |
9461aad to
b0e669f
Compare
|
I switched to static images. It's not perfect (should ideally be .svg instead of .png) but I'd argue it's good enough and we can always improve it later on. |
|
|
||
| html_static_path = ['attachment/doc'] | ||
|
|
||
| html_css_files = [ |
There was a problem hiding this comment.
In other pending PR, I used the following:
html_static_path = ['_static']
html_css_files = ['css/custom.css']There was a problem hiding this comment.
Not sure I understand what changes you want here
There was a problem hiding this comment.
I would like you to move the CSS in the _static directory and update conf.py according to that, like what I did here:
I think PNGs are better than SVG here. The images could have a transparent background but it is good enough 👍 |
|
Look at the space between the color image, the name and the code: It seems there is too much space between the color code and the color name. This PR made the color image and color name closer, looks better. |
|
Fixups should have fixed most comments - I will squash once deemed ready to merge. |
|
|
||
| .. container:: swatch-item | ||
|
|
||
| .. image:: /attachment/doc/visual_guide/swatches/q-gray-base.svg |
There was a problem hiding this comment.
Not using an empty :alt: produces a bad result with Sphinx. You need to be explicit, just like the font images above.
See QubesOS/qubes-issues#10765
Note: GenAI was used to replicate the template of https://www.qubes-os.org/doc/visual-style-guide/