Skip to content

Internal proposers#333

Draft
supersaiyansubtlety wants to merge 28 commits intoQuiltMC:develop/2.8from
supersaiyansubtlety:internal-proposers
Draft

Internal proposers#333
supersaiyansubtlety wants to merge 28 commits intoQuiltMC:develop/2.8from
supersaiyansubtlety:internal-proposers

Conversation

@supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Nov 9, 2025 •
edited
Loading

based on #340 rebased

Very early draft of internal proposers which will be used to make several fixes and improvements:

  • Enums:
    • prevent renaming of enum constants (but still propose their names)
  • Record components; default record component getters should automatically get their component's name #314
    • propose getter names matching the corresponding field already implemented
    • prevent directly naming definite getters
    • allow indirectly renaming the field corresponding to the getter via the getter instead
    • give the getter the same highlighting as the field
  • Anomymous class synthetic fields corresponding to outer method params; Issue with lost parameter connection #252
    • propose field names matching the corresponding param
    • allow indirectly renaming params corresponding to fields via the fields
    • give the field the same highlighting as the param

@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 9, 2025
@supersaiyansubtlety supersaiyansubtlety added bug Something isn't working enhancement new feature or request backend affects the enigma backend wip in progress labels Nov 9, 2025
@supersaiyansubtlety supersaiyansubtlety force-pushed the internal-proposers branch 5 times, most recently from b85e5bb to 9288418 Compare November 9, 2025 20:58
This was linked to issues Nov 16, 2025
Issue with lost parameter connection #252
Open
default record component getters should automatically get their component's name #314
Open
@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Nov 18, 2025
Merged
@supersaiyansubtlety supersaiyansubtlety changed the base branch from develop/2.7 to develop/2.8 November 18, 2025 15:44
@supersaiyansubtlety
minor refactors
1385596
@supersaiyansubtlety
remove some param linking invalidation that isn't relevant to local c…
4071b93 
…lass synthetic fields
@supersaiyansubtlety
get param synthetic field proposals working... for bytecode only
e312a5d
@supersaiyansubtlety
get *some* param fake local proposals working for vineflower
f4e83bb
@supersaiyansubtlety
offset fake local indices when there are multiple
87f2b89
@supersaiyansubtlety
fix accidentally checking innerName instead of outerName when finding…
ddaf22d 
… local/anonymous classes
@supersaiyansubtlety
offset fake locals by synthetic field index instead of counting acces…
aa2b040 
…ses in a method
@supersaiyansubtlety
rename new services and visitor
49ca2f7
@supersaiyansubtlety
simplify ParamLocalClassLinkingVisitor method collection
68ccbfe
@supersaiyansubtlety
extract EnigmaProject::getNameTarget from EntryReference::getNameable…
4d6bc0c 
…Entry and use it in DeclarationSNippetPanel::resolveTarget
@supersaiyansubtlety
rename EntryReference::getNameableEntry -> getNameTarget to match the…
deca432 
… method in EnigmaProject

extract EnigmaProject::getRepresentative which doesn't special-case constructors
use getRepresentative instead of getNameTarget in DeclarationSnippetPanel::resolveTarget
use getRepresentative in AbstractEditorPanel::resolveReference
@supersaiyansubtlety
add ParamLocalClassLinksTest with one initial test
08be404
@supersaiyansubtlety
fix limiting localSyntheticFieldsByGetterByOwner to one field per getter
4183d14
@supersaiyansubtlety
use only consider linked synthetic fields when calculating fake local…
1a28c25 
… offsets

fix inconsistent issues related to a single invoker param linked to multiple invoked params
@supersaiyansubtlety
show linked param info in IdentifierPanel for fake locals
26630c3
@supersaiyansubtlety
more fake local spaghetti
8d3ed8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels

backend affects the enigma backend bug Something isn't working enhancement new feature or request wip in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

default record component getters should automatically get their component's name Issue with lost parameter connection

1 participant

@supersaiyansubtlety