inverting the logic to favor newer versions of electrs#51
Merged
RCasatta merged 1 commit intoRCasatta:masterfrom Jan 25, 2023
Merged
inverting the logic to favor newer versions of electrs#51RCasatta merged 1 commit intoRCasatta:masterfrom
RCasatta merged 1 commit intoRCasatta:masterfrom
Conversation
ulrichard
force-pushed
the
feature/jsonrpc-import
branch
from
1a9bf5c to
16a4666
Compare
ulrichard
changed the title
ulrichard
force-pushed
the
feature/jsonrpc-import
branch
2 times, most recently
from
9bf38fa to
246e213
Compare
Contributor
Author
|
Tested with locally installed binaries: |
ulrichard
force-pushed
the
feature/jsonrpc-import
branch
2 times, most recently
from
c0a585e to
76934c8
Compare
ulrichard
commented
Dec 29, 2022
| { | ||
| vec!["-vvv"] | ||
| } else { | ||
| vec!["--log-filters", "debug"] |
Contributor
Author
There was a problem hiding this comment.
maybe "info" would be enough, as it is really quite verbose like this.
Or even better, remove it entirely for the else case. The user can use the RUST_LOG env var.
What do you think?
Owner
There was a problem hiding this comment.
Yeah, makes sense to remove it if it works through the RUST_LOG env var
ulrichard
force-pushed
the
feature/jsonrpc-import
branch
from
76934c8 to
f29c46e
Compare
Owner
|
Concept ACK |
ulrichard
force-pushed
the
feature/jsonrpc-import
branch
from
f29c46e to
78efe90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.