Skip to content

Fix hover func arg#346

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken:fix-hover-func-arg
Oct 2, 2020
Merged

Fix hover func arg#346
renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken:fix-hover-func-arg

Conversation

@renkun-ken
Copy link
Member

Close #345

This PR fixes the XPath to find if the last definition is a function and adds some test cases.

@renkun-ken renkun-ken requested a review from randy3k September 30, 2020 16:15
@randy3k
Copy link
Member

randy3k commented Oct 1, 2020

It seems some strange things are going in the tests.

@renkun-ken
Copy link
Member Author

renkun-ken commented Oct 1, 2020

Looks like something isn't working properly in CI runners recently.

@renkun-ken
Copy link
Member Author

All tests of my open PRs are working locally though.

@randy3k
Copy link
Member

randy3k commented Oct 1, 2020

Thank you for confirming it. I really want to fix the CI issues first.

@renkun-ken
Copy link
Member Author

Sure. I'll take a look too when I could.

@renkun-ken renkun-ken merged commit 9c267a0 into REditorSupport:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover on symbol in a function with functional argument causes parse error

2 participants