Remove '(' from completion trigger chars#374
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom Jan 30, 2021
Merged
Remove '(' from completion trigger chars#374renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken merged 1 commit intoREditorSupport:masterfrom
Conversation
Member
|
No problem. :) (I actually turned it off manually). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having experienced the #369, using
(as a completion trigger character is in most cases too eager: once the completion is triggered, the new typed character won't trigger the computation of completions in a while. In practice, this will usually disable many other completion items or leave no change for them to show up.Therefore, I'd like to revert that change by removing
(from completion trigger characters.