Add code action to disable linters#408
Merged
randy3k merged 11 commits intoREditorSupport:masterfrom Jun 24, 2021
Merged
Conversation
Member
Author
|
I'd like to merge this PR to enable code actions to support only "Disable all linters for this line" before how lintr settles down how individual linters could be disabled. |
Member
|
It makes sense to me to merge the PR. It will be great if you could come up with some tests though. |
Member
Author
|
Yes, I'm working on some test cases for this. |
This reverts commit 94c029d.
Member
Author
|
Not sure why windows check not passing. |
Member
Author
|
Looks like the windows build does not use the latest pushed version since the log does not contain the diagnostics in |
Member
|
Looks like |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables CodeAction and provides the following code actions:
# nolintin the end of the line if a linter complains).Disablesome_linterfor this lineThere is an open discussion at r-lib/lintr#720 about disabling specific linters. In the future, we could add code action to disable specific linters that produce diagnostics for certain lines. The development version of lintr already supports disabling specific linters: