Unpublish diagnostics when disabled#498
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Nov 21, 2021
Merged
Conversation
Member
|
Thank you. LGTM. |
randy3k
approved these changes
Nov 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #497
This PR unpublishes diagnostics of all workspace documents when diagnostics is disabled from client settings.
Also, this PR corrects the signature of
protocol_set_tracetoprotocol_set_trace(self, params). This handler turns on/offdebugpreviously, which might cause conflicts withr.lsp.debugsince if it istruebut the language server trace is not turnoed on, then on the server side the debug will be enabled on startup but then disabled due tosetTracenotification saysoff.I add a new
tracesetting parallel withdebugas well aslogger$traceso that they have no conflicts.logger$infoworks if eitherdebugortraceis on, andlogger$traceonly works iftraceis on.