Drop diagnostics on callback if disabled#577
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom Oct 13, 2022
Merged
Drop diagnostics on callback if disabled#577renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken merged 1 commit intoREditorSupport:masterfrom
Conversation
randy3k
reviewed
Oct 13, 2022
Member
randy3k
left a comment
randy3k
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
I think a new release is due and we should release an update.
Member
Author
|
Yes, agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes REditorSupport/vscode-R#1196
If the client opens a document before the language server receives settings from the client, diagnostics will be triggered (which is default). If diagnostics is disabled,
diagnostics_callbackwill still publish the diagnostics results, which is undesirable.This PR corrects this behavior by checking diagnostics settings again before publishing results. At this point, it is most likely for the server to have already received the settings from the client.