-
Notifications
You must be signed in to change notification settings - Fork 176
Compiler Promotion: Update LLVM/SPIRV/Hipify Submodules (Nov24 -> Jan05) #3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Required llvm changes available in this promotion. llvm/llvm-project#138928 Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks good, however checking for the patch deletion, I noticed that the PR description is misleading.
The PR description says diff should be ROCm/llvm-project@985b939...a0ab125 but links to ROCm/llvm-project@985b939...63a5e6d. Commit a0ab125 (also noted in the table) seems not be on the llvm-project repo.
Please fix this and re-request a review afterwards. Furthermore, some PyTorch builds are failing but I am not sure if those build failures are pre-existing or due to the compiler promotion.
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
I've updated the PR description with patch deletion details.
Since a0ab125 is merge commit, diff doesn’t work with ROCm/llvm-project@985b939...a0ab125, so updated the link with 63a5e6d (HEAD commit of this merge PR/commit a0ab125). Now, I’ve updated the llvm submodule with following commits included and updated the PR description and started the full TheRock build. https://github.com/ROCm/TheRock/actions/runs/21867546224 |
Overview
This PR updates the compiler submodules for TheRock build:
amd-llvmsubmodulehipifysubmodulespirv-llvm-translatorsubmodulepatches/amd-mainline/llvm-project/0003-HACK-Handle-ROCM-installation-layout-of-lib-llvm-bin.patchSubmodule Updates
985b9393123662d59429da6338cc0eaeb113bceafaCommit Ranges
Time Period: November 24, 2025 → January 05, 2026
LLVM Version Information
Base Version: clang version 22.0.0
Major Version Change: No
Test Plan
Test Results
https://github.com/ROCm/TheRock/actions/workflows/release_portable_linux_pytorch_wheels.yml?query=branch%3Ausers%2Flajagapp%2Fcompiler-jan05-promo