Skip to content

Conversation

@lajagapp
Copy link
Contributor

@lajagapp lajagapp commented Feb 6, 2026

Overview

This PR updates the compiler submodules for TheRock build:

  • amd-llvm submodule
  • hipify submodule
  • spirv-llvm-translator submodule
  • Removed patches/amd-mainline/llvm-project/0003-HACK-Handle-ROCM-installation-layout-of-lib-llvm-bin.patch

Submodule Updates

Submodule Current Commit New Commit
amd-llvm 985b939 3123662
hipify d59429d a6338cc
spirv-llvm-translator 0eaeb11 3bceafa

Commit Ranges

Time Period: November 24, 2025 → January 05, 2026

LLVM Version Information

Base Version: clang version 22.0.0
Major Version Change: No

Test Plan

  • Full TheRock build (Linux & Windows)
  • PyTorch build with new compiler

Test Results

Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Required llvm changes available in this promotion.
llvm/llvm-project#138928

Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good, however checking for the patch deletion, I noticed that the PR description is misleading.

The PR description says diff should be ROCm/llvm-project@985b939...a0ab125 but links to ROCm/llvm-project@985b939...63a5e6d. Commit a0ab125 (also noted in the table) seems not be on the llvm-project repo.

Please fix this and re-request a review afterwards. Furthermore, some PyTorch builds are failing but I am not sure if those build failures are pre-existing or due to the compiler promotion.

Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
@lajagapp
Copy link
Contributor Author

CI looks good, however checking for the patch deletion, I noticed that the PR description is misleading.

The PR description says diff should be ROCm/llvm-project@985b939...a0ab125 but links to ROCm/llvm-project@985b939...63a5e6d. Commit a0ab125 (also noted in the table) seems not be on the llvm-project repo.

Please fix this and re-request a review afterwards. Furthermore, some PyTorch builds are failing but I am not sure if those build failures are pre-existing or due to the compiler promotion.

I've updated the PR description with patch deletion details.

Removed 0003-HACK-Handle-ROCM-installation-layout-of-lib-llvm-bin.patch: This patch is removed since related llvm change available as part of this llvm promotion (ROCm/llvm-project@8871e9e - Nov27 commit)

Since a0ab125 is merge commit, diff doesn’t work with ROCm/llvm-project@985b939...a0ab125, so updated the link with 63a5e6d (HEAD commit of this merge PR/commit a0ab125).

Now, I’ve updated the llvm submodule with following commits included and updated the PR description and started the full TheRock build.

3123662d3ea2 2026-02-06 10:02:10 -0500  Cherry-pick ea32b336 from amd-staging (#1368)
75d3e7621da0 2026-02-04 22:51:24 -0500  Cherry-picks: 61f272d and be9ba44 to amd-mainline (#1351)
6f7f6c567eeb 2026-02-04 18:06:58 -0500  Revert "AMDGPU: Fix runtime unrolling when cascaded GEPs present (#147700) (#1349)
b233f4cea18c 2026-02-04 17:25:15 +0000  [AMDGPU] Add machineFunctionInfo to recent MIR tests (#179602)
4bf1d207e402 2026-02-04 15:01:32 +0000  [AMDGPU] Pre-GFX10 does not need added latency for workgroup fences (#177157)
a0ab125feef2 2026-02-04 00:00:52 -0500  Bulk Promotion from 2026 01 05 (#1325)

https://github.com/ROCm/TheRock/actions/runs/21867546224
https://github.com/ROCm/TheRock/actions/runs/21867552352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants