[CI] Integrate manifest diff into nightly builds (Part 3/3)#3302
Draft
amd-hsivasun wants to merge 5 commits intomainfrom
Draft
[CI] Integrate manifest diff into nightly builds (Part 3/3)#3302amd-hsivasun wants to merge 5 commits intomainfrom
amd-hsivasun wants to merge 5 commits intomainfrom
Conversation
This script generates HTML reports comparing submodule versions between two TheRock commits, with support for: - Superrepo component-level analysis (rocm-libraries, rocm-systems) - Submodule - Status detection: added, removed, changed, unchanged, reverted
- Add 24 tests covering pure functions, mocked API calls, and integration scenarios for the generate_manifest_diff_report.py script - Fix ImportError: use gha_query_workflow_run_by_id (correct function name) instead of gha_query_workflow_run_information Co-authored-by: Cursor <cursoragent@cursor.com>
Allow specifying a custom output directory for the generated HTML report. When --output-dir is provided, the script creates the directory (if needed) and writes TheRockReport.html there. This makes integration with CI workflows easier, as the report can be written directly to a reports/ directory for upload scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds a reusable workflow for generating manifest diff reports that can be: - Triggered manually via workflow_dispatch - Called from other workflows via workflow_call Supports three modes: - find-last-successful: Compare against last successful workflow run - workflow-mode: Use workflow run IDs instead of commit SHAs - Direct commit SHA comparison Co-authored-by: Cursor <cursoragent@cursor.com>
Add a job to automatically generate the manifest diff report during nightly CI runs. The report compares from the last successful nightly to the current commit, providing visibility into what changed. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Automatically generate manifest diff reports during nightly CI runs to provide visibility into what changed since the last successful nightly build.
This is Part 3/3 of the manifest diff report feature (split from #2161).
Technical Details
Add
generate_manifest_diffjob to.github/workflows/ci_nightly.yml:manifest-diff.ymlreusable workflowfind_last_successful: "ci_nightly.yml"to find the start commitend_commit: ${{ github.sha }}for the current commitThe job runs independently of other nightly jobs and does not block them.
Test Plan
generate_manifest_diffjob runs successfullyTest Result
Pending nightly run after merge.
Submission Checklist