Add flattening support to artifact_manager#3315
Merged
Conversation
The patch for testing was developed with assistance from Cursor AI.
ScottTodd
approved these changes
Feb 11, 2026
build_tools/artifact_manager.py
Outdated
Comment on lines
227
to
239
| log(f" ++ Flattening {archive_path.name}") | ||
| flattener = ArtifactPopulator( | ||
| log(f" ++ Flattening {archive_path.name} to {output_dir}") | ||
| populator = ArtifactPopulator( | ||
| output_path=output_dir, verbose=False, flatten=True | ||
| ) | ||
| flattener(archive_path) | ||
| populator(archive_path) |
Member
There was a problem hiding this comment.
I could see keeping the variable name flattener here. It's a populator with flatten=True and it's only used in this narrow scope.
Could also use a more verbose name like flattening_populator :P
Member
Author
There was a problem hiding this comment.
No strong feelings from my side just felt more consistent the proposed way. Switched back to what it was :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch for testing was developed with assistance from Cursor AI.