[debug-tools/rocgdb] Extract rocgdb launcher from cmake file #3322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging other folks to get additional build folks to review |
Currently we embed the rocgdb launcher in the cmake file. Now that we have a working integration of the debug tools, clean this up and extract it to its own file. That way we can just install it during rocgdb's build.
lumachad
force-pushed
the
users/lumachad/therock/rocgdb/launcher
branch
from
581536f to
40174eb
Compare
Contributor
Author
|
Adding @amd-shahab from the debugger team to help with another pair of eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we embed the rocgdb launcher in the cmake file. Now that we have a working integration of the debug tools, clean this up and extract it to its own file. That way we can just install it during rocgdb's build.