Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RDNA (consumer GPU) coverage to the existing Flash Attention Triton integration workflow by running the same job on both CDNA (MI355) and RDNA3 runners in parallel, improving CI validation for the Triton backend across supported AMD architectures.
Changes:
- Convert the Triton integration job to a matrix strategy to run on both MI355 and RDNA3 runners.
- Make job names and benchmark artifacts/logs architecture-specific to avoid collisions across matrix runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
valarLip
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The triton backend of flash attention is used on consumer cards (RDNA) in addition to datacenter cards (CDNA). This adds an RDNA CI runner (aiter-gfx1100) to the existing flash_attention_integration workflow via matrix strategy so both architectures are tested in parallel. This is a follow up to #1974
Technical Details
Test Plan
Test Result
Submission Checklist