Skip to content

Fix error checking in aiter_hip_common.h#2225

Open
draganmladjenovic wants to merge 1 commit intomainfrom
draganm/error_checking
Open

Fix error checking in aiter_hip_common.h#2225
draganmladjenovic wants to merge 1 commit intomainfrom
draganm/error_checking

Conversation

@draganmladjenovic
Copy link
Contributor

Motivation

HIP_CALL is using exit(0) thus hiding issues in the CI

Technical Details

Use std::abort

Test Plan

Check CI

Test Result

TBD

Submission Checklist

@draganmladjenovic draganmladjenovic requested a review from a team March 9, 2026 17:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:multi-gpu Multi-GPU op tests (8 GPU)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2225 --add-label <label>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants