-
Notifications
You must be signed in to change notification settings - Fork 260
Build CK on Windows #3458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vpietila-amd
wants to merge
30
commits into
develop
Choose a base branch
from
vpietila/ck-on-windows
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Build CK on Windows #3458
+357
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into vpietila/ck-on-windows
…osable_kernel into vpietila/ck-on-windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enable building CK on Windows. The Windows build assumes that TheRock is installed to the standard location. Main changes:
CMakeLists.txt, I enabled HIP language only after the HIP package found. Otherwise the configuration step fails on Windows. The master CMakeLists.txt has some Windows platform specific changes for finding the ROCm installation because the paths are slightly different on Windows.minandmaxutility functions that the MSVC compiler complains about. Only impacts Windows platform.getenvdeprecation warning on Windows platform in the env var utilities.joinable_thread, created a no-op implementation on Windows platform. No functional change on Linux platform.