Skip to content

Conversation

@ThruptiRajLakshmanaGowda
Copy link
Contributor

@ThruptiRajLakshmanaGowda ThruptiRajLakshmanaGowda commented Dec 19, 2025

Proposed changes

This PR enables support for the AMD gfx950 GPU architecture in the CK tile engine GEMM operations.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables support for the AMD gfx950 GPU architecture in the CK tile engine GEMM operations. The change removes the previous TODO comment and adds gfx950 to the list of supported GPU targets.

  • Added gfx950 to the list of desired GPU targets for GEMM operations
  • Added CI pipeline stage for testing TILE_ENGINE_GEMM operations on gfx950 hardware

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tile_engine/ops/gemm_streamk/CMakeLists.txt Added gfx950 to DESIRED_TARGETS list for GEMM StreamK operations
Jenkinsfile Added new CI stage to run TILE_ENGINE_GEMM tests on gfx950 hardware with various data types and layouts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ThruptiRajLakshmanaGowda ThruptiRajLakshmanaGowda changed the title [CK TILE ENGINE] Enable gfx950 for supported combination [CK TILE ENGINE] Enable gfx950 GPU architecture for supported combination Dec 19, 2025
-D GEMM_DATATYPE="fp8;fp16" \
-D GEMM_LAYOUT="rcr" \
-D GEMM_STREAMK_DATATYPE="fp8;fp16" \
-D GEMM_STREAMK_LAYOUT="rcr" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to support for different layouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants