Skip to content

Conversation

@afagaj
Copy link
Collaborator

@afagaj afagaj commented Dec 23, 2025

Proposed changes

Summary
Previously, the code used unsigned long for literals and format specifiers to represent 64-bit unsigned values. While this worked on Linux, it caused compatibility issues on Windows.
Background
The C++ standard does not guarantee that long is 64 bits. On LP64 systems (e.g., Linux), long maps to 64-bit values, but on LLP64 systems (e.g., Windows), long maps to 32-bit values. This discrepancy led to incorrect behavior when assuming unsigned long was always 64-bit.
Fix
This PR updates all relevant literals and format specifiers to explicitly use 64-bit unsigned types, ensuring consistent behavior across platforms.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@afagaj afagaj changed the title Update UL literals and format specifiers to work correctly in Windows Ensure Consistent 64-Bit Unsigned Handling Across OS Platforms Dec 23, 2025
@afagaj afagaj requested a review from DDEle December 23, 2025 21:07
@afagaj afagaj force-pushed the afagaj/os-independent-bit-widths branch 4 times, most recently from 9e60c14 to b3c34dd Compare December 23, 2025 22:32
@afagaj afagaj force-pushed the afagaj/os-independent-bit-widths branch from b3c34dd to bab23bd Compare December 23, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants