Merged
Conversation
pruthvistony
previously approved these changes
May 5, 2025
jithunnair-amd
requested changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes correspond to pytorch/pytorch#151845 (and syncs changes from pytorch's hipify as part of this PR). torch's hipify version 2 significantly simplifies the the cuda to hip mappings, including a BC-breaking change of no longer using caffe2 mappings and getting rid of the Masquerading files. In order to ease the transition, hipify_torch will contain both versions of the mappings. An attempt is made to check which version of torch is installed and use the right mappings, otherwise the v1 mappings are used unless the caller specifies --v2.