Skip testEighTinyNorm test 0.8.0#695
Merged
AratiGanesh merged 2 commits intorocm-jaxlib-v0.8.0from Feb 10, 2026
Merged
Conversation
|
okay LGTM but one suggestion I was asked to do this change in upstream so I don't want you to get the same comment once you push upstream. other than that changes looks okay. something like # numerical errors seen as of ROCm 7.2 due to hipsparse issue
# TODO: re-enable the test once the hipsparse is fixed |
AratiGanesh
force-pushed
the
skip-eigh-tiny-norm
branch
from
32c152c to
f1d29bb
Compare
AratiGanesh
changed the title
AratiGanesh
added
open-upstream
AratiGanesh
force-pushed
the
skip-eigh-tiny-norm
branch
from
42f49ce to
5ff4b5d
Compare
AratiGanesh
force-pushed
the
skip-eigh-tiny-norm
branch
from
5ff4b5d to
9422367
Compare
gulsumgudukbay
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The testEighTinyNorm test fails on ROCm devices due to numerical precision issues in the underlying hipSolver https://ontrack-internal.amd.com/browse/SWDEV-578349
Technical Details
Added @jtu.skip_on_devices("rocm") decorator to skip testEighTinyNorm in `tests/linalg_test.py
Test Result
Submission Checklist
Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.