Skip ann_test test_pmap on ROCm due to IndivisibleError#773
Open
AratiGanesh wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 5966834)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AnnTest::test_pmapfails on ROCm withjax._src.sharding.IndivisibleError: shape=[1, 2, 4] is incompatible with mesh_shape=...after the JAX 0.8.2 → 0.9.1 bump.Inside
jax.pmap,lax.approx_min_k(..., aggregate_to_topk=False)produces an XLA SPMD tile{devices=[1,2,4]<=[8] last_tile_dim_replicate}. JAX 0.9.x's new_gspmd_to_named_sharding_via_mesh→parse_flatten_op_shardingpath then tries to translate this 3-D tile back into the 1-D pmap mesh of size 8 and fails, since[1, 2, 4]cannot factor into a 1-D mesh.Technical Details
Cherry-pick of upstream commit
596683446be555baf6dbf7803d45e51eb33bdcd1ontorocm-jaxlib-v0.9.1. Adds a ROCm-onlyskipTestguard inAnnTest.test_pmap(tests/ann_test.py):if jtu.is_device_rocm():
self.skipTest("IndivisibleError: SPMD tiling incompatible with 1D pmap mesh on ROCm")