Closed
Conversation
dsidler
requested review from
AtlantaPepsi,
JhaShweta1,
KawtharShafie,
PedramAlizadeh,
akolliasAMD,
corey-derochie-amd,
edgargabriel,
gilbertlee-amd,
haripriyaayyalasomayajula,
mberenjk,
mustafabar,
nileshnegi,
nusislam,
thananon and
wenkaidu
as code owners
Author
|
Ideally I would like to update to an even newer commit however this will require more changes on the rccl side since mscclpp starts implementing additional |
Contributor
|
@nusislam This will likely conflict with your open PR. |
Contributor
yeah..this PR has to wait. |
Author
|
Closing since #1488 got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mscclpp submodule to PR 411.
This requires changes to the cmake options passed to the submodule.
The read-allred.patch was updates so it can still be applied.