Skip to content

SPU: Silence some warnings #15675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elad335 merged 1 commit into from
Jun 7, 2024
Merged

SPU: Silence some warnings #15675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions rpcs3/Emu/Cell/SPUCommonRecompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6310,8 +6310,6 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
ra.value = ra.is_const() ? spu_ls_target(ra.value, op.si10 * 4) : 0;
const u32 offs = ra.is_const() ? 0 : spu_ls_target(0, op.si10 * 4);
const u32 abs_diff = calculate_absolute_ls_difference(offs, 0);
const u32 const_flags = u32{ra.is_const()} + u32{atomic16.ls.is_const()};
const u32 const_lsa_flags = u32{ra.is_const()} + u32{_lsa.is_const()};

if ((_lsa.unequal_with_mask_indifference(ra, SPU_LS_MASK_128) && offs == 0) ||
(_lsa.compare_with_mask_indifference(ra, SPU_LS_MASK_1) && abs_diff >= 128u) ||
Expand Down
5 changes: 2 additions & 3 deletions rpcs3/Emu/Cell/SPULLVMRecompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,7 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator
m_ir->SetInsertPoint(_body);
}

void putllc16_pattern(const spu_program& prog, utils::address_range range)
void putllc16_pattern(const spu_program& /*prog*/, utils::address_range range)
{
// Prevent store elimination
m_block->store_context_ctr[s_reg_mfc_eal]++;
Expand Down Expand Up @@ -1231,7 +1231,6 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator
return;
}

const u64 rtime = _spu->rtime;
rsx::reservation_lock rsx_lock(raddr, 128);

// Touch memory
Expand Down Expand Up @@ -1399,7 +1398,7 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator
m_ir->SetInsertPoint(_final);
}

void putllc0_pattern(const spu_program& prog, utils::address_range range)
void putllc0_pattern(const spu_program& /*prog*/, utils::address_range /*range*/)
{
// Prevent store elimination
m_block->store_context_ctr[s_reg_mfc_eal]++;
Expand Down