Skip to content

MacOs/Arm64: Try to fix shortcuts#16125

Merged
Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:hidsds
Sep 26, 2024
Merged

MacOs/Arm64: Try to fix shortcuts#16125
Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:hidsds

Conversation

@Megamouse

@Megamouse Megamouse commented Sep 25, 2024

Copy link
Copy Markdown
Contributor
  • Shortcuts: Try to create shortcut link path if it doesn't exist
  • Shortcuts/ MacOs/Arm64: Add more plist entries for shortcuts
  • Adds macOs and linux hidapi files to the VisualStudio filters for improved input debugging

maybe fixes #16017

@Megamouse Megamouse changed the title VS: add mac and linux hidapi files for improved input debugging VS: add macOs and linux hidapi files for improved input debugging Sep 25, 2024
@Megamouse Megamouse changed the title VS: add macOs and linux hidapi files for improved input debugging MacOs/Arm64: Try to fix shortcuts Sep 25, 2024
@darkuser89

Copy link
Copy Markdown
Bildschirmfoto 2024-09-26 um 16 36 14 works

@schm1dtmac

schm1dtmac commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Bildschirmfoto 2024-09-26 um 16 36 14 works

Desktop shortcut creation itself would be fine after PR #16120 sorted out icon creation, the remaining issues are with launching them on arm64 (prompts for Rosetta on master) and creating Launchpad shortcuts (doesn’t create necessary directories if not present), those are what this PR targets fixing so you should test those two things.
I’ll test on my machine when I get time later today as well.

@darkuser89

Copy link
Copy Markdown
Bildschirmaufnahme.2024-09-26.um.16.59.47.mov

create and start works for me.

@schm1dtmac

schm1dtmac commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Ran some tests on my M2 MacBook Air that does not have Rosetta installed, Launchpad shortcuts now create successfully without issue even if the user Applications dir doesn't already exist, and all shortcuts now launch fine on arm64 without prompting for Rosetta, so that solves the issues listed in #16017.

The only nitpick I'll mention (not affected by changes made in this PR, may file as a separate issue) is the shortcut's launcher script specifies the exact path of RPCS3 (e.g. open "/Applications/RPCS3.app") which may break if the bundle is moved. macOS has a means to avoid this as you can use -b to specify bundle IDs instead of app names/paths in the open command (e.g. open -b net.rpcs3.rpcs3) so that should ensure RPCS3 is opened no matter where the bundle is located.

@Megamouse Megamouse merged commit 9e460eb into RPCS3:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [macOS arm64] Creating launchpad shortcuts is broken in numerous ways

3 participants