-
Notifications
You must be signed in to change notification settings - Fork 4
Add favicon support for MCP server #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """ | ||
| Custom HTTP routes and utilities for LamPyrid MCP server. | ||
|
|
||
| This module provides custom HTTP route handlers that are served at the root level, | ||
| alongside the MCP protocol endpoints. | ||
| """ | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| from fastmcp import FastMCP | ||
| from starlette.requests import Request | ||
| from starlette.responses import FileResponse, JSONResponse | ||
|
|
||
|
|
||
| def get_project_root() -> Path: | ||
| return Path(__file__).parent.parent.parent | ||
|
|
||
|
|
||
| def get_assets_path(filename: str) -> Path: | ||
| return get_project_root() / 'assets' / filename | ||
|
|
||
|
|
||
| async def serve_favicon(request: Request): | ||
| """Serve favicon.ico file at the root level.""" | ||
| favicon_path = get_assets_path('favicon.ico') | ||
| if favicon_path.exists(): | ||
| return FileResponse(favicon_path, media_type='image/x-icon') | ||
| return JSONResponse({'error': 'Not found'}, status_code=404) | ||
|
|
||
|
|
||
| def register_custom_routes(mcp: FastMCP) -> None: | ||
| """ | ||
| Register custom HTTP routes with the FastMCP server. | ||
|
|
||
| These routes are served at the root level (e.g., /favicon.ico), | ||
| not nested under the MCP protocol path (e.g., /mcp). | ||
|
|
||
| Args: | ||
| mcp: The FastMCP server instance | ||
| """ | ||
| # Register favicon route | ||
| mcp.custom_route('/favicon.ico', methods=['GET'])(serve_favicon) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.