Added contributor information regarding pre-commit#549
Open
cansik wants to merge 1 commit intoRangiLyu:mainfrom
Open
Added contributor information regarding pre-commit#549cansik wants to merge 1 commit intoRangiLyu:mainfrom
cansik wants to merge 1 commit intoRangiLyu:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 74.80% 74.76% -0.05%
==========================================
Files 71 71
Lines 4695 4695
Branches 731 731
==========================================
- Hits 3512 3510 -2
- Misses 986 987 +1
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Same issue about nanodet/model/arch/one_stage_detector.py. No idea why this fails now and didn't before. I am only changing the README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is not clear just because the file is around, I added a short chapter about how to format the code to contribute. Maybe it even makes sense to bump the isort version anyways to at least
5.12.0.