-
Notifications
You must be signed in to change notification settings - Fork 11
Code and assets identifiers #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
198985f
d2cd450
824942c
3959e0d
e33fbdc
a7cc2d9
2d00459
37e906f
8d9be0a
585bc9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,14 @@ export const readProject = async (projectIdentifier, locale, accessToken) => { | |
| ); | ||
| }; | ||
|
|
||
| export const loadAssets = async (assetsIdentifier, locale, accessToken) => { | ||
| const queryString = locale ? `?locale=${locale}` : ""; | ||
| return await get( | ||
| `${host}/api/projects/${assetsIdentifier}/images${queryString}`, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm unfamiliar with the admin side, will the query string ever change the assets returned? e.g. can we have a Spanish locale image vs an English locale image?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess potentially, maybe if there's text in there or something, or they want to provide a more culturally relevant image? The locale query string makes it load up a different project anyway, so it is possible to do this. |
||
| headers(accessToken), | ||
| ); | ||
| }; | ||
|
|
||
| export const readProjectList = async (page, accessToken) => { | ||
| return await get(`${host}/api/projects`, { | ||
| params: { page }, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.