Skip to content

Spike web component#96

Merged
ArayB merged 11 commits intomainfrom
spike-web-component
May 19, 2022
Merged

Spike web component#96
ArayB merged 11 commits intomainfrom
spike-web-component

Conversation

@ArayB
Copy link
Contributor

@ArayB ArayB commented May 9, 2022 •
edited
Loading

Quick spike to prototype adding a web component which can use the editor react components. This behaviour should allow us to build a stand alone web component that can be consumed by astro pi.

  • Ejects create react app
  • Adds a webcomponent which then mounts react components inside
  • React components used in the Web component need to have their styles injected using the style-it package. Otherwise the styling isn't applied due to them being mounted on the shadow-dom.

The style-it use could cause issues where react components are used both in the web component and the UI application.

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented May 9, 2022

  • CircleCI build #376
  • Test coverage: 41%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented May 17, 2022

  • CircleCI build #392
  • Test coverage: 40%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented May 19, 2022

  • CircleCI build #406
  • Test coverage: 40%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented May 19, 2022

  • CircleCI build #407
  • Test coverage: 62%

@ArayB ArayB marked this pull request as ready for review May 19, 2022 10:20
@raspberrypigithubbot
Copy link

raspberrypigithubbot commented May 19, 2022

  • CircleCI build #410
  • Test coverage: 62%

loiswells97
loiswells97 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good to me 👍

@ArayB ArayB merged commit 34487c4 into main May 19, 2022
@ArayB ArayB deleted the spike-web-component branch May 19, 2022 13:55
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
69bf0a2 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wwrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
@floehopper floehopper mentioned this pull request May 28, 2024
Merged
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
58f6d15 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore
bb99d9f 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
floehopper added a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused ComponentStore (#1023)
ca69c29 
This was introduced in #96, but never used. I suspect the `import store
from "./app/store"` statement in `src/web-component.js` was intended to
import it, but it used the wrong filename.

`ComponentStore` was later effectively replaced by `WebComponentStore`
in #728.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArayB @raspberrypigithubbot @loiswells97