Merged
Conversation
|
floehopper
force-pushed
the
remove-broken-format-script
branch
from
24a61cc to
c249a4c
Compare
floehopper
temporarily deployed
to
previews/remove-broken-format-script
GitHub Actions
Inactive
|
This script is broken, because no `.prettierrc` file is included in the repo. We're relying on the `prettier` plugin for `eslint` to do code formatting & checking, e.g. in `.github/workflows/ci-cd.yml` where we invoke `yarn lint` [1] to check the formatting. Similarly, the `lint:fix` script can be used to apply formatting. So the `format` script is redundant and potentially confusing to new developers. [1]: https://github.com/RaspberryPiFoundation/editor-ui/blob/5197facfc6253be548205d24e89478af286eb384/.github/workflows/ci-cd.yml#L31-L32
floehopper
force-pushed
the
remove-broken-format-script
branch
from
c249a4c to
a45cb1f
Compare
|
Contributor
Author
Thanks, @danhalson. I seem to have lost your review approval by rebasing the branch and fixing the conflicts. Any chance you could re-add it? |
danhalson
approved these changes
Apr 29, 2024
floehopper
added a commit
that referenced
this pull request
May 9, 2024
The items were all listed under the "Added" heading, but I'm pretty confident #976 & #991 were effectively internal fixes that had no impact on clients of the web component, and it feels like it's worth highlighting #1003 as a *change* to the existing behaviour rather than the addition of a new feature.
floehopper
added a commit
that referenced
this pull request
May 9, 2024
### Added - Support to enable embedding iframes in HTML projects from in-house domains (#985) - Dispatch event when project identifier changes, e.g. after project is remixed (#2830) - Add `load_remix_disabled` attribute to web component (#992) ### Changed - Invalidate cached project when project is remixed (#1003) ### Fixed - Unit tests for `pyodide` runner (#976) - Remove broken `format` script (#991)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is broken, because no
.prettierrcfile is included in the repo.We're relying on the
prettierplugin foreslintto do code formatting & checking, e.g. in.github/workflows/ci-cd.ymlwhere we invokeyarn lintto check the formatting.Similarly, the
lint:fixscript can be used to apply formatting. So theformatscript is redundant and potentially confusing to new developers.