Gitlab CI, patch tests for ancient R#7629
Merged
ben-schwen merged 3 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7629 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 87 87
Lines 16890 16890
=======================================
Hits 16726 16726
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inst/tests/tests.Rraw
Outdated
| test(2359.1, nchar(fread(txt)$foo), 409600L) | ||
|
|
||
| # rowwiseDT() valid and invalid handling of complex objects #7219 | ||
| # NB \(x) only exists pre-parser and is changed to function(x) x during parsing |
Member
There was a problem hiding this comment.
I don't think the comment makes much sense, I think we can leave it out
MichaelChirico
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our CI is nearly all green, but we see two errors on test-lin-ancient-cran due to different behavior of tests on versions.
This is due to anonymous function (introduced in R 4.1.0) and
as.Date.numeric(x, origin)errors whenoriginis not supplied.