Skip to content

bug: Patch option widgets move and leave value behind after their value is changed #2187

@KobeW50

Description

@KobeW50

Bug description

When a patch has two or more text patch options, if you set one or more (but not all) patch options and then touch the screen outside the input area on the widget, the location of the patch option widgets will move. The topmost widgets with non-default input will move to the bottom of the list, and the empty widgets that were below will take their places and inherit the values.

I strongly recommend watching this recording with sound enabled (I narrate what I'm doing and what I'm trying to show):

YouCut_20240902_023837698.mp4

Steps to reproduce

  1. Open the patch option menu of a patch with two or more text patch options.

  2. Change the value of the topmost patch option.

  3. Tap anywhere on the screen (except a patch option textbox or toggle).

Expected behavior: Nothing should occur.

Actual behavior: The changed patch option widget will move to the bottom of the patch options list, and the next text-based widget in line that did not have its value changed will now have the value that you specified in step 2.

Logs

revanced-manager_logcat_20240902021851799653.log.txt

Version of ReVanced Manager and version & name of app you are patching

Manager 1.21.2

YouTube 19.16.39

ReVanced Manager logs

Uploaded above

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug reportSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions