Conversation
There was a problem hiding this comment.
🥞🏗️ Infra LGTM!
?(.asc)is not supported in GitHub actions (I think).
Correct, ?(.asc) is an extended glob, GitHub supports only standard posix flavoured glob
Also,
assembleReleasedo not produce any .asc file so maybe that line can be removed.
According to this task configuration
https://github.com/ReVanced/revanced-manager/blob/compose-dev/app/build.gradle.kts#L241
I believe on every assembleRelease it should generate .asc file.
|
I also commited the |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI flow issues by adjusting dependency names, improving the release workflow with GPG key import, and correcting artifact upload patterns.
- Rename the semantic-release plugin dependency in package.json
- Add GPG key import step and update APK subject path in release workflow
- Split artifact upload paths in the PR build workflow to handle .apk and .asc files explicitly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Update semantic-release plugin dependency name |
| .github/workflows/release.yml | Add GPG import step; update APK subject-path |
| .github/workflows/build_pull_request.yml | Expand artifact upload paths to .apk and .apk.asc |
Comments suppressed due to low confidence (2)
package.json:4
- Verify that the NPM package name is correct—if the plugin is scoped under
@revanced, retaining the scoped name (@revanced/gradle-semantic-release-plugin) may be necessary to resolve it correctly.
"gradle-semantic-release-plugin": "^1.10.1",
.github/workflows/build_pull_request.yml:33
- The
.apk.ascartifact isn’t produced byassembleRelease, so this upload path will fail. Remove this line or setif-no-files-found: warnto avoid CI errors when the file is missing.
app/build/outputs/apk/release/revanced-manager*.apk.asc
?(.asc)is not supported in GitHub actions (I think). Also,assembleReleasedo not produce any .asc file so maybe that line can be removed.https://github.com/brosssh/revanced-manager/actions/runs/15465948686/job/43537932873