chore: isolated module set to true, exports split to export type#6800
Closed
ziv wants to merge 2 commits intoReactiveX:masterfrom
Closed
chore: isolated module set to true, exports split to export type#6800ziv wants to merge 2 commits intoReactiveX:masterfrom
ziv wants to merge 2 commits intoReactiveX:masterfrom
Conversation
Member
|
Hi @ziv, unfortunately, we already had an attempt to introduce I'd close this PR, but since it also includes |
Member
|
Closing this. It doesn't seem like this is solving any issues we're currently having. Thank you for your contribution, @ziv . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In order to be more compatible with ESM and other bundlers or TypeScript environment (Babel and Deno, for example), isolatedModules flag should be turned on.
This PR contain only this change in tsconfig and fix some build error (replace "export" with "export type" for interfaces).
Reference:
https://www.typescriptlang.org/tsconfig#isolatedModules
All tests and build pass.