tests, net, l2_bridge: mark interface stability scenarios as t3#4619
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA module-level Pytest marker ChangesTest Marker Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-4
requested review from
azhivovk,
frenzyfriday,
orelmisan and
servolkov
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-virtualization-qe-bot
added
lgtm-coderabbitai[bot]
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4619 published |
azhivovk
approved these changes
Apr 28, 2026
azhivovk
left a comment
azhivovk
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Also need to backport this change to cnv-4.18-4.21
Contributor
Author
|
/verified Used the new tier3 lane for verification. |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1654 🏁 Script executed: Length of output: 41 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Contributor
Author
|
/check-can-merge |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-4619. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
Contributor
Author
|
/cherry-pick cnv-4.21 |
|
Cherry-picked PR tests, net, l2_bridge: mark interface stability scenarios as t3 into cnv-4.21: #4895 |
acinko-rh
pushed a commit
to acinko-rh/openshift-virtualization-tests
that referenced
this pull request
May 19, 2026
…tQE#4626) ##### What this PR does / why we need it: `reviews.instructions` is not a valid field in the CodeRabbit schema v2 and is silently dropped at parse time, meaning the PR template validation rules we defined there were never enforced. This migrates the instructions to `reviews.path_instructions` with a `"**"` glob, which is the correct schema v2 mechanism for applying repo-wide review instructions. Root cause was surfaced by CodeRabbit itself in PR RedHatQE#4619: the field was silently ignored because the schema defines `reviews` with `additionalProperties: false`. ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: The instruction content is identical — only the enclosing field was changed to comply with the schema. ##### jira-ticket: <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated code review validation to the v2 schema and applied the PR template validation rules repository-wide via a path-based selector to preserve existing enforcement. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Edward Haas <edwardh@redhat.com> Signed-off-by: Adam Cinko <acinko@redhat.com>
acinko-rh
pushed a commit
to acinko-rh/openshift-virtualization-tests
that referenced
this pull request
May 19, 2026
…atQE#4619) ##### Short description: Relocate Interface Stability scenarios from Tier 2 to Tier 3 to optimize CI pipeline performance. ##### What this PR does / why we need it: This PR migrates the Interface Stability test suite to the Tier 3 lane to optimize our CI resource allocation. These scenarios require a five-minute monitoring period per test, totaling approximately 15 minutes of execution time. By moving these tests from Tier 2, which runs three times a week, to the weekly Tier 3 cadence, we significantly reduce the execution load on our mid-week lanes. This adjustment ensures that Tier 2 remains lean and focused on providing faster feedback loops for frequent integration checks while still maintaining essential long-term stability coverage on a weekly basis. ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: The test logic remains identical; only the execution tier/metadata has been updated to reflect the new weekly cadence. This change aligns with our goal to prioritize Tier 2 for faster, high-frequency signals. ##### jira-ticket: <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Marked all tests in the interface stability test module as tier3, ensuring uniform classification across contained tests (including those with other markers). This improves test organization, filtering, and execution categorization for stability-related test runs. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Anat Wax <awax@redhat.com> Signed-off-by: Adam Cinko <acinko@redhat.com>
Contributor
Author
|
/cherry-pick cnv-4.20 |
|
Cherry-picked PR tests, net, l2_bridge: mark interface stability scenarios as t3 into cnv-4.20: #4915 |
Contributor
Author
|
/cherry-pick cnv-4.19 |
Contributor
Author
|
/cherry-pick cnv-4.18 |
Contributor
|
Cherry-picked PR tests, net, l2_bridge: mark interface stability scenarios as t3 into cnv-4.19: #4955 |
|
Cherry-picked PR tests, net, l2_bridge: mark interface stability scenarios as t3 into cnv-4.18: #4956 |
acinko-rh
pushed a commit
to acinko-rh/openshift-virtualization-tests
that referenced
this pull request
Jun 18, 2026
…ity scenarios as t3 (RedHatQE#4915) Cherry-pick from `main` branch, original PR: RedHatQE#4619, PR owner: Anatw Signed-off-by: Anat Wax <awax@redhat.com> Co-authored-by: Anat Wax <awax@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Relocate Interface Stability scenarios from Tier 2 to Tier 3 to optimize CI pipeline performance.
What this PR does / why we need it:
This PR migrates the Interface Stability test suite to the Tier 3 lane to optimize our CI resource allocation. These scenarios require a five-minute monitoring period per test, totaling approximately 15 minutes of execution time. By moving these tests from Tier 2, which runs three times a week, to the weekly Tier 3 cadence, we significantly reduce the execution load on our mid-week lanes. This adjustment ensures that Tier 2 remains lean and focused on providing faster feedback loops for frequent integration checks while still maintaining essential long-term stability coverage on a weekly basis.
Which issue(s) this PR fixes:
Special notes for reviewer:
The test logic remains identical; only the execution tier/metadata has been updated to reflect the new weekly cadence. This change aligns with our goal to prioritize Tier 2 for faster, high-frequency signals.
jira-ticket:
Summary by CodeRabbit