refactor: contract setup compression #885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
KolevDarko,
alexandre-abrioux,
benjlevesque and
kevindavee
alexandre-abrioux
approved these changes
Jul 12, 2022
Contributor
alexandre-abrioux
left a comment
alexandre-abrioux
left a comment
There was a problem hiding this comment.
Perfect! Very good refacto 👍
packages/smart-contracts/scripts-create2/contract-setup/setupETHConversionProxy.ts
Outdated
Show resolved
Hide resolved
packages/smart-contracts/scripts-create2/contract-setup/setups.ts
Outdated
Show resolved
Hide resolved
KolevDarko
approved these changes
Jul 12, 2022
KolevDarko
reviewed
Jul 12, 2022
| * @param contractAddress address of the BatchPayments Proxy | ||
| * @param hre Hardhat runtime environment | ||
| */ | ||
| const setupBatchPayments = async ( |
Contributor
There was a problem hiding this comment.
this setupBatchPayments is the same function from setupBatchPayments.ts
You can import that one here right ?
romtref
commented
Jul 12, 2022
Contributor
Author
romtref
left a comment
romtref
left a comment
There was a problem hiding this comment.
renamed deploy-one.ts and verify-one.ts to deploy.ts and verify.ts
Contributor
|
moved to #888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Factorization of 3 contract setup scripts into 1