Merged
Conversation
Richienb
requested changes
Mar 17, 2021
Owner
Richienb
left a comment
There was a problem hiding this comment.
Looks good - just some minor nitpicks
Richienb
reviewed
Mar 17, 2021
Contributor
Author
|
Is there any thing left to do? |
Owner
|
There's a couple meta tweaks I gotta do but regardless, I'll get it merged in a day or so. |
|
May it will be more useful just to allow Boolean options new NodePolyfillPluginOptions ({
Buffer: true,
console: true,
process: true
}) |
Contributor
Author
@constgen If so, users need to understand what polyfills this plugin provided, and what polyfills their project or project dependency need. |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #5
Fixes #8, Fixes #7
View rendered readme.md