Skip to content

Allow aliases to be skipped#6

Merged
Richienb merged 2 commits intoRichienb:masterfrom
Edge00:master
Mar 28, 2021
Merged

Allow aliases to be skipped#6
Richienb merged 2 commits intoRichienb:masterfrom
Edge00:master

Conversation

@Edge00
Copy link
Contributor

@Edge00 Edge00 commented Mar 17, 2021

Refer to #5

Fixes #8, Fixes #7


View rendered readme.md

Copy link
Owner

@Richienb Richienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just some minor nitpicks

@Edge00 Edge00 requested a review from Richienb March 17, 2021 10:43
@Richienb Richienb changed the title feat: add option to specify aliases to skip adding Allow aliases to be skipped Mar 18, 2021
@Edge00
Copy link
Contributor Author

Edge00 commented Mar 18, 2021

Is there any thing left to do?

@Richienb
Copy link
Owner

There's a couple meta tweaks I gotta do but regardless, I'll get it merged in a day or so.

@constgen
Copy link

May it will be more useful just to allow Boolean options

new NodePolyfillPluginOptions ({
  Buffer: true,
  console: true,
  process: true
})

@Edge00
Copy link
Contributor Author

Edge00 commented Mar 26, 2021

May it will be more useful just to allow Boolean options

new NodePolyfillPluginOptions ({
  Buffer: true,
  console: true,
  process: true
})

@constgen If so, users need to understand what polyfills this plugin provided, and what polyfills their project or project dependency need.

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb merged commit 32a61a6 into Richienb:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't remove console when used this plugin together with Terser Plugin

3 participants

Comments